Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): non interactive migrate #6461

Merged
merged 3 commits into from
Apr 3, 2023
Merged

feat(cli): non interactive migrate #6461

merged 3 commits into from
Apr 3, 2023

Conversation

dtarnawsky
Copy link
Contributor

This adds a non-interactive option for cap migrate so:
npx cap migrate --noprompt --packagemanger pnpm

will migrate to cap 5 without requiring user interaction and use pnpm as the package manager. Package manager can be npm, yarn, pnpm

@dtarnawsky dtarnawsky requested a review from markemer April 3, 2023 16:10
markemer
markemer approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@markemer markemer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. You need to run npm run fmt though.

markemer
markemer approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@markemer markemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you run fmt, we're good.

@dtarnawsky
Copy link
Contributor Author

Compiling is failing but it worked for me locally - did you forget to check something in that I also have?

Just pushed another update to make typescript happy.

@markemer markemer mentioned this pull request Apr 3, 2023
Merged
@dtarnawsky dtarnawsky merged commit 53dfeaf into main Apr 3, 2023
@dtarnawsky dtarnawsky deleted the migrate-non-interactive branch April 3, 2023 18:33
markemer pushed a commit that referenced this pull request Apr 17, 2023
@dtarnawsky @markemer
feat(cli): non interactive migrate (#6461)
79c2c55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markemer markemer markemer approved these changes

@theproducer theproducer theproducer approved these changes

@giralte-ionic giralte-ionic giralte-ionic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dtarnawsky @markemer @theproducer @giralte-ionic