fix(cli): Pin @ionic/utils-subprocess version for node 12 support #6524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
markemer,
theproducer,
ItsChaceD,
IT-MikeS and
giralte-ionic
markemer
approved these changes
Apr 20, 2023
|
I think we should also edit the 4.x docs to say node 12 as this is the least disruptive option so we don't cause errors for those using 4.x on 12. |
IT-MikeS
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest release of @ionic/utils-subprocess doesn't work on node 12.
While docs say that Capacitor 4 supports node 14 and newer, on code it requires node 12.4 or newer, so I think it should still work there.
Or if not, we should change the node check to require node 14 so the users see an error about the node version being unsupported rather than a weird message