Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for Amazon Fire WebView #6603

Merged
merged 10 commits into from
Nov 28, 2023
Merged

feat: support for Amazon Fire WebView #6603

merged 10 commits into from
Nov 28, 2023

Conversation

arcadius
Copy link
Contributor

Fir for #6602

@arcadius arcadius changed the title Support for Amazon Fire https://github.com/ionic-team/capacitor/issue… Support for Amazon Fire WebView #6602 May 17, 2023
@arcadius arcadius changed the title Support for Amazon Fire WebView #6602 Support for Amazon Fire WebView May 17, 2023
@arcadius
Copy link
Contributor Author

@markemer , please have a look at this PR please

@markemer
Copy link
Member

@markemer , please have a look at this PR please

I can, but can you include a sample project for an Amazon Fire Tablet?

@markemer markemer added type: feature request A new feature, enhancement, or improvement and removed type: feature request A new feature, enhancement, or improvement labels May 30, 2023
@markemer markemer self-assigned this Jul 11, 2023
@markemer markemer changed the title Support for Amazon Fire WebView feat: support for Amazon Fire WebView Jul 11, 2023
@markemer markemer added the type: feature request A new feature, enhancement, or improvement label Jul 28, 2023
@markemer
Copy link
Member

Can you run npm run fmt? Otherwise things are looking good.

@markemer markemer merged commit 3cb4eb8 into ionic-team:main Nov 28, 2023
6 checks passed
theproducer pushed a commit that referenced this pull request Dec 14, 2023
Co-authored-by: Mark Anderson <[email protected]>
Co-authored-by: Mark Anderson <[email protected]>
Co-authored-by: Chace Daniels <[email protected]>
theproducer added a commit that referenced this pull request Dec 14, 2023
Co-authored-by: Arcadius Ahouansou <[email protected]>
Co-authored-by: Mark Anderson <[email protected]>
Co-authored-by: Mark Anderson <[email protected]>
Co-authored-by: Chace Daniels <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request A new feature, enhancement, or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants