fix(cli): signing type option issue #6716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markemer
reviewed
Jul 11, 2023
markemer
reviewed
Jul 11, 2023
markemer
reviewed
Jul 11, 2023
markemer
requested changes
Jul 11, 2023
markemer
changed the title
markemer
requested review from
markemer,
ItsChaceD,
IT-MikeS,
giralte-ionic,
theproducer and
jcesarmobile
markemer
approved these changes
Jul 13, 2023
markemer
approved these changes
Jul 14, 2023
giralte-ionic
approved these changes
Jul 14, 2023
This comment was marked as abuse.
This comment was marked as abuse.
IT-MikeS
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two revision.
The first one is to correct the
commanderuse case, if a option is named with b-, it will change to the Camel Case.The second is to load the all android build options, not only the options for
apksigner.