Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): remove certificate file extension check on copy #7240

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

jcesarmobile
Copy link
Member

At the moment the SSL pinning plugin only supports DER formatted certificates (binary) on iOS, which should have .der extension, not .cer, and other formats are not supported at the moment, so the error message is confusing for users.
And on Android it supports multiple formats and extensions.

I'm working on adding support for base64 formatted certificates to the SSL pinning plugin and also make the plugin log if there was a problem with any of the certificates, because at the moment it fails silently, so I think the .cer extension check can be removed.

An alternative if we don't want to remove the check would be to expand the file extension list.

Copy link
Member

@markemer markemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We certainly want to be rid of this, since the warning shows up when you do the right thing and if you do what it suggests, it will actually fail. However, we might want to add a check later when we expand our options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants