fix(cli): remove certificate file extension check on copy #7240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the SSL pinning plugin only supports DER formatted certificates (binary) on iOS, which should have
.der
extension, not.cer
, and other formats are not supported at the moment, so the error message is confusing for users.And on Android it supports multiple formats and extensions.
I'm working on adding support for base64 formatted certificates to the SSL pinning plugin and also make the plugin log if there was a problem with any of the certificates, because at the moment it fails silently, so I think the
.cer
extension check can be removed.An alternative if we don't want to remove the check would be to expand the file extension list.