Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Remove PostCSS warning #1364

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Remove PostCSS warning #1364

merged 1 commit into from
Aug 24, 2018

Conversation

StefanRein
Copy link
Contributor

This removes following warning:

Remove warning: Without from option PostCSS could generate wrong source map or do not find Browserslist config. Set it to CSS file path or to undefined to prevent this warning

from: the input file name (most runners set it automatically).
Source: https://github.com/postcss/postcss

Fixes #1359 #13763
#1359
ionic-team/ionic-framework#13763

Short description of what this resolves:

This removes the PostCSS warning, which is resulting in an error in our automated builds.

Changes proposed in this pull request:

  • Just add from field with an undefined value, as mentioned in the warning.

Fixes: #1359 #13763

This removes following warning:

Remove warning: Without `from` option PostCSS could generate wrong source map or do not find Browserslist config. Set it to CSS file path or to `undefined` to prevent this warning

`from: the input file name (most runners set it automatically).`
Source: https://github.com/postcss/postcss

Fixes ionic-team#1359 #13763
ionic-team#1359
ionic-team/ionic-framework#13763
@krishnakumarik
Copy link

krishnakumarik commented Jan 10, 2018

In which file i have to add the from field.actually i have a from field in ionic-app-scripts-package.json. and from filed is having the value like this "@ionic/app-scripts@latest".now what i have to do.plz help me out.
and in my project postcss version is "6.0.13",

@krishnakumarik
Copy link

ok founded in sass.js .it is working.

@con17man
Copy link

thanks @krishnakumarik

you can find sass.js file under /node_modules/@ionic/app-scripts/dist/sass.js.
inside search for var postcssOptions and add from: undefined,.

it should look like this:

var postcssOptions = {
    from: undefined,
    to: path_1.basename(sassConfig.outFile),
    map: autoPrefixerMapOptions
};

@StefanRein
Copy link
Contributor Author

@krishnakumarik @con17man You should not modify any files in the node_modules directory. If you update packages, reinstall them, installing them in a new project, any modifications are gone.

I did write here some suggestions how to solve this temporarily, so you don't have to modify files in the node_modules folder: ionic-team/ionic-framework#13763

@OooOooosss
Copy link

Modifying the sass.ts file can solve the problem, but it's not a good way to do it

@bleuscyther
Copy link

+1

@imhoffd
Copy link
Contributor

imhoffd commented Aug 24, 2018

Thank you @StefanRein much appreciated 😄

@imhoffd imhoffd merged commit 1e2035e into ionic-team:master Aug 24, 2018
trsrm added a commit to powwowinc/ionic-app-scripts-tiny that referenced this pull request Jan 2, 2019
3.1.9:
* fix(2889): fix build error with --prod
* fix(serve): start listening when watch is ready
* fix(live-server): update android platform path (ionic-team#1407)
* docs(changelog): 3.1.9

3.1.10:
* Update node-sass dependency (ionic-team#1435)
Updating node-sass dependency from 4.7.2 to 4.9.0 to make it works with node 10 on windows (build fail with ionic start)
* chore(package): bump deps (ionic-team#1421)
* chore(deps): no package lock
* chore(changelog): 3.1.10

3.1.11:
* fix(serve): fix EADDRINUSE issue with dev logger server
fixes ionic-team/ionic-cli#3368
fixes ionic-team/ionic-cli#1678
fixes ionic-team/ionic-cli#1830
fixes ionic-team/ionic-cli#1721
fixes ionic-team/ionic-cli#1866
fixes ionic-team/ionic-cli#1808
fixes ionic-team/ionic-cli#3022
* docs(changelog): 3.1.11 changes

3.2.0:
* feat(environments): configuration via process.env.VAR replacement (ionic-team#1471)
* fix(sass): remove PostCSS warning (ionic-team#1364)
This removes following warning:
Remove warning: Without `from` option PostCSS could generate wrong source map or do not find Browserslist config. Set it to CSS file path or to `undefined` to prevent this warning
`from: the input file name (most runners set it automatically).`
Source: https://github.com/postcss/postcss
Fixes ionic-team#1359 #13763
ionic-team#1359
ionic-team/ionic-framework#13763
* fix(serve): use wss protocol for secure websocket when page is using https (ionic-team#1358)
* docs(changelog): 3.2.0

3.2.1:
* docs(readme): add note about existing declaration
addresses ionic-team/ionic-cli#3541
* chore(deps): update webpack to 3.12.0 (ionic-team#1477)
* chore(deps): bump node-sass to 4.9.3 to fix security warnings (ionic-team#1483)
* chore(deps): bump node-sass to 4.10.0 to fix security warnings (ionic-team#1493)
* docs(changelog): 3.2.1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config file from webpack not found
7 participants