Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Use localhost instead of 0.0.0.0 when injecting live reload script #450

Merged
merged 1 commit into from
Dec 5, 2016
Merged

Conversation

imgx64
Copy link
Contributor

@imgx64 imgx64 commented Nov 22, 2016

Short description of what this resolves:

When the dev server listens on 0.0.0.0, it injects a live reload script that looks like this: <script src="//0.0.0.0:35729/livereload.js?snipver=1" async="" defer=""></script>. This PR replaces 0.0.0.0 with localhost in this case.

@danbucholtz
Copy link
Contributor

@jthoms1,

I'm not sure what affect this will have. Do you have any idea?

Thanks,
Dan

@MELAS007
Copy link

@imgx64 - where to replace this?

@imgx64
Copy link
Contributor Author

imgx64 commented Nov 30, 2016

@MELAS007 I don't understand your question. If you're getting the 0.0.0.0 live reload script, you can run ionic serve --address localhost as a workaround until this gets merged.

Copy link
Contributor

@jthoms1 jthoms1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me.

@jthoms1 jthoms1 merged commit 7f8a0c3 into ionic-team:master Dec 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants