This repository has been archived by the owner on May 1, 2020. It is now read-only.
fix(serve): assign all ports dynamically #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up to now only the logger port was dynamically increased if another app is running already. This meant that manually specifying port arguments for server and live reload was needed when directly using the `ionic-app-scripts server` command. The `ionic` CLI command does already take care of this. This patch ensures all the ports are chosen dynamically, so it's now possible to run two applications without any manual intervention.
|
Looks like the builds are broken. Will investigate... |
|
Missed to adapt the tests. Will do and create a new PR. Also filed #730 so we might prevent this from happening again;-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Up to now only the logger port was dynamically increased if another app
is running already. This meant that manually specifying port arguments
for server and live reload was needed when directly using the
ionic-app-scripts servercommand. TheionicCLI command doesalready take care of this.
Changes proposed in this pull request:
This patch ensures all the ports are chosen dynamically, so it's now
possible to run two applications without any manual intervention.
Fixes: #694