Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: React/Vue Quickstart guides use legacy form control syntax #3327

Closed
averyjohnston opened this issue Dec 15, 2023 · 0 comments · Fixed by #3415
Closed

content: React/Vue Quickstart guides use legacy form control syntax #3327

averyjohnston opened this issue Dec 15, 2023 · 0 comments · Fixed by #3415
Labels
content Issues related to the contents of the documentation website

Comments

@averyjohnston
Copy link
Contributor

URL

https://ionicframework.com/docs/react/quickstart, https://ionicframework.com/docs/vue/quickstart

Issue Description

Under "A component with style," both pages have code snippets that use the legacy syntax for ion-checkbox (see checkbox docs page for more info).

The surrounding content in the section also references the syntax and will need updating as well; examples:

  • The checkbox is currently slotted in an ion-item, which is used to explain the slot property. The explanation may need to be changed to refer to the ion-badge instead.
  • On the React page, the checkbox is referred to as not having any children, but this will change if the label text is moved into the default slot.

There may be other nearby things that need tweaking. The entire section should be reviewed to ensure everything still makes sense.

@averyjohnston averyjohnston added triage New issues content Issues related to the contents of the documentation website labels Dec 15, 2023
@ionitron-bot ionitron-bot bot removed the triage New issues label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Issues related to the contents of the documentation website
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant