Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ion-Scroll Zooming Broken on Android #1439

Closed
jedibatman opened this issue May 19, 2014 · 3 comments
Closed

Ion-Scroll Zooming Broken on Android #1439

jedibatman opened this issue May 19, 2014 · 3 comments

Comments

@jedibatman
Copy link

Pinch-to-Zoom is currently not working for the ion-scroll directive for any platform that isn't iOS.

I have outlined the issue here.

Additionally, I have implemented a fix to the issue here.

I have done my best to respect the coding conventions, though I have two main concerns that I would like to address.

  • Since this is platform specific, am I expected (or is it possible) to write a test for it?
  • I read the information related to the conventional-changelog plugin that is used to make commits, but am not really understanding how it is supposed to actually be used.

Any insight or guidance would be much appreciated.

Regards,
Jared

@somethingnew2-0
Copy link

Awesome! I opened a pull request for you. @ajoslin can probably check to see if this can be merged in.

@ajoslin
Copy link
Contributor

ajoslin commented Jun 4, 2014

Merged via #1440

@ajoslin ajoslin closed this as completed Jun 4, 2014
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants