Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: components that are not accessible with the keyboard #18548

Closed
4 tasks
brandyscarney opened this issue Jun 14, 2019 · 7 comments
Closed
4 tasks

bug: components that are not accessible with the keyboard #18548

brandyscarney opened this issue Jun 14, 2019 · 7 comments
Assignees
Labels
a11y Accessibility related issues package: core @ionic/core package type: bug a confirmed bug report

Comments

@brandyscarney
Copy link
Member

brandyscarney commented Jun 14, 2019

Bug Report

Ionic version:

[x] 4.x

The following components have issues with their focused states and keyboard navigation:

  • Slides
    • Can't navigate easily
  • Item
    • In a menu with routerLink it focuses but you have to tab twice to make enter work
    • Requires tabbing twice to get through the list
    • Buttons inside of a disabled tab can still get tabbed to
  • Segment (MD and iOS)
    • Not receiving focused state
    • Can tab and activate disabled segment buttons
  • Datetime
    • There is no way to navigate datetime using the keyboard

This list is not comprehensive and will be added to if needed.

@ionitron-bot ionitron-bot bot added the triage label Jun 14, 2019
@brandyscarney brandyscarney added package: core @ionic/core package type: bug a confirmed bug report labels Jun 14, 2019
@ionitron-bot ionitron-bot bot removed the triage label Jun 14, 2019
@amymarsh4work
Copy link
Contributor

@brandyscarney Hi Brandy! Our app uses the datetime and segment components. Our UX\Accessibility team has raised the issues with us internally as well. I'm interested in helping with these, but would work on them one at a time. The datetime seems one of the more challenging components, so would not tackle that one right away.

Would your team be opposed to an issue be created for each component? It seems like the commits would be easier for your team to get through the pipeline and approved if they are kept small. Would you consider these bugs or feature requests?

@brandyscarney
Copy link
Member Author

@amymarsh4work Hey! Thank you for wanting to help, again! I can also help with any questions.

I would be fine with an issue for each component. I wanted to open this to keep track of all of the problems with navigating, but I can just link the issues here. 🙂 We consider them bugs because it should be working. If any changes to the API are made (properties or new components added) it would be considered a feature.

@amymarsh4work
Copy link
Contributor

Deal. I'll open individual bug cards as I'm working through fixing them and commit with the 'fix' prefix. Thanks for being so helpful! You guys are nice to work with. 👍

@brandyscarney brandyscarney added this to the Ionic for Desktop milestone Sep 25, 2019
@brandyscarney
Copy link
Member Author

Hey @amymarsh4work could you either email me or post your email here for me to delete right after? [email protected]

Looking to see if you'd like to be added to our Slack for discussion. Let me know! 🙂

@brandyscarney brandyscarney modified the milestones: Ionic for Desktop, a11y Oct 2, 2020
@willmartian willmartian self-assigned this Jun 17, 2021
@liamdebeasi liamdebeasi added the a11y Accessibility related issues label Jul 19, 2021
@liamdebeasi liamdebeasi removed this from the a11y milestone Jul 19, 2021
@liamdebeasi
Copy link
Contributor

Thanks for the issue! The issues in the original post have been resolved, so I am going to close this out.

ion-slides was deprecated in Ionic 6, and this issue is likely fixed in a newer version of Swiper.js. Please see https://ionicframework.com/docs/api/slides#migration for more information. Additionally, datetime was revamped in Ionic 6 to be useable on desktop.

For any additional bugs, please open a new issue. Thank you!

@ionitron-bot
Copy link

ionitron-bot bot commented Feb 19, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y Accessibility related issues package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

4 participants