-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Modal with router #21854
Comments
Thanks for the feature request. I am going to close this as this is not something we are looking to add to the framework at this time. We do not feel that it would be correct to take a temporary component such as That being said, opening a single modal (even if opened multiple times) should have a very small performance footprint. Are you running into performance issues when opening a modal in Ionic Framework? |
Not like any major lag, requests can be cached, but there is a tiny rendering dealy, mainly because of the the other heavy computation, context does fix this issue as well, just thought it would be a good to have feature. |
There is a feature request open for a reusable modal (I.e. reusing the modal instance): #20263. If this is something that would be useful for your application, I would recommend posting a use case on that thread (An example of the performance issues you are running into currently would be great too!). These are very helpful when the team meets to figure out which features to add to the framework. Thanks! |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Feature Request
Ionic version:
[x] 5.x
Describe the Feature Request
Having a modal which is always present in the Dom (once activated for the first time, like tabs).
Many times, same modal is presented multiple times, and rendering it every single time is expensive.
React Native Expo does uses the same thing, bind modal to a route, can we expect this is ionic 6 maybe?
Describe Preferred Solution
Describe Alternatives
Related Code
Additional Context
The text was updated successfully, but these errors were encountered: