Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issues with ion-fab button #22296

Closed
mastergogo opened this issue Oct 12, 2020 · 3 comments · Fixed by #26619
Closed

Accessibility issues with ion-fab button #22296

mastergogo opened this issue Oct 12, 2020 · 3 comments · Fixed by #26619
Labels
a11y Accessibility related issues package: core @ionic/core package type: bug a confirmed bug report

Comments

@mastergogo
Copy link

Below are a few observations for improvements:

When checked with Iphone's screen reader (Voice over), it has been observed that fab buttons are always announced as "close (icon name) button" when the user double taps on the buttons, more interactive options appears such as social media icons when navigating on the social media icons, Voice over announces as "close (social media icon name)", issues here is that voice-over announces close every time user interacts with it which is an incorrect announcement until the close button appears it should not announce close, it should only announce the name and the role of a button that is currently in focus.

below are steps to reproduce:

  1. please open the link in Apple device such as iPhone and turn on voice over
  2. once the voice-over is on, please navigate to the fab-button and observe the announcement
  3. it will be announced as a "close (icon-name) button", however, the close button is behind the fab button which is not activated yet but the voiceover still announces it.
  4. when double tapped on the fab button, voice-over announces the close button as close, however, it announces all the social media icons as close, which is again incorrect.

Let me know if more info is needed to reproduce.

Thanks,
Amit

@ionitron-bot ionitron-bot bot added the triage label Oct 12, 2020
@brandyscarney brandyscarney added this to the a11y milestone Oct 13, 2020
@brandyscarney brandyscarney added package: core @ionic/core package type: bug a confirmed bug report labels Nov 12, 2020
@liamdebeasi liamdebeasi added the a11y Accessibility related issues label Jul 19, 2021
@liamdebeasi liamdebeasi removed this from the a11y milestone Jul 19, 2021
@RenAlbiorix
Copy link

Is there any update when this issue can be fixed? All ion-fab button reads as close because inside shadow-root <ion-icon part="close-icon" ... is getting added regardless of icon used in ion-fab button. Below is screenshot from ionic site.
image

@liamdebeasi liamdebeasi added type: bug a confirmed bug report and removed type: bug a confirmed bug report labels May 23, 2022
@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #26619, and a fix will be available in an upcoming release of Ionic Framework. We also launched a new accessibility section of the ion-fab docs that notes devs should provide a label to the ion-fab-button.

@ionitron-bot
Copy link

ionitron-bot bot commented Feb 18, 2023

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y Accessibility related issues package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants