Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(refresher): import icons to avoid errors in react and vue #24525

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jan 6, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #24480

The asset path for Ionicons is not set when using custom elements build. As a result, we cannot lazy load icons internally. We should be using the icon SVG data anyways as it results in additional maintenance overhead (I.e. https://github.com/ionic-team/ionic-framework/blob/main/packages/vue/src/index.ts#L154-L169);

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 6.0.1-dev.1641502305.cfaa4b3

@liamdebeasi liamdebeasi requested a review from a team as a code owner January 6, 2022 20:36
@github-actions github-actions bot added the package: core @ionic/core package label Jan 6, 2022
@mamitry
Copy link

mamitry commented Feb 22, 2022

In which release did this fix get into?

@averyjohnston
Copy link
Contributor

This was in 6.0.2. You can view release notes with a list of merged PRs here: https://ionicframework.com/docs/reference/release-notes

@mamitry
Copy link

mamitry commented Feb 22, 2022

Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Uncaught TypeError: Failed to construct 'URL': Invalid base URL
4 participants