Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(item): error slot visible in Safari #24579

Merged
merged 1 commit into from
Jan 14, 2022
Merged

fix(item): error slot visible in Safari #24579

merged 1 commit into from
Jan 14, 2022

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The error slot of the ion-item is never visible in Safari.

Issue Number: #24575

What is the new behavior?

Adjusts the style ordering so that the error slot display overrides correctly on all browser targets.

Does this introduce a breaking change?

  • Yes
  • No

Other information

You can verify this change by running the Core project:

@sean-perkins sean-perkins requested a review from a team as a code owner January 14, 2022 17:20
@github-actions github-actions bot added the package: core @ionic/core package label Jan 14, 2022
Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I wonder if this'll fix some of the other error slot issues being reported too.

@sean-perkins
Copy link
Contributor Author

sean-perkins commented Jan 14, 2022

@amandaesmith3 hopefully a few! Another active discussion is that implementers expect the error text to only display after the control has ben interacted with, instead of when the control is only invalid. This isn't initially how we designed the feature, so we would need to regroup on what this means and if there's a better API pattern that would allow customizing that default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants