fix(menu): focus trapping with menu and overlays no longer results in errors

[liamdebeasi]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build (npm run build) was run locally and any changes were pushed
• Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Issue Number: resolves #24491 resolves #24361
There are two issues in one here.

1. The overlay focus trapping code was firing whenever the menu was focus, but it should have only been firing on the overlay that was open. This resulted in the focus trapping code continually firing (cause of the infinite loop).
2. Even after this was resolved, the menu focus trapping code was always firing on an overlay. So even if you got the overlay to open, focus would never be moved to it since menu would keep claiming it.

What is the new behavior?

• Overlay focus trapping does not fire if ion-menu is focused.
• Menu focus trapping does not fire is overlays are focused.
• Menu allows focus to be relinquished when it is being moved to an overlay (except toast).

Does this introduce a breaking change?

• Yes
• No

Other information

Dev build: 6.0.4-dev.1642703076.3d49fbe

[liamdebeasi]

Don't review, I found a bug

[liamdebeasi]

Bug fixed. All set for review!

[averyjohnston]

Looks great! I played around with it and everything held up 👍