Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: popover arrow on desktop does not display #24624

Closed
4 of 6 tasks
peterpeterparker opened this issue Jan 21, 2022 · 5 comments · Fixed by #25056
Closed
4 of 6 tasks

bug: popover arrow on desktop does not display #24624

peterpeterparker opened this issue Jan 21, 2022 · 5 comments · Fixed by #25056
Labels
package: core @ionic/core package type: bug a confirmed bug report v6 issues specific to Framework v6

Comments

@peterpeterparker
Copy link
Contributor

peterpeterparker commented Jan 21, 2022

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x

Current Behavior

Until Ionic v6, popover with mode set to iOS were presented with an arrow regardless of the device i.e. arrows were displayed for popover even on desktop.

Ionic v6 breaks this behavior and do not display arrows on desktop anymore and thus in any case i.e even if the @Prop() arrow is set to true (see code).

This changes may have been introduced in PR #23258.

Expected Behavior

As in Ionic v5 and previous versions, being able to present popover on desktop with an arrow

Steps to Reproduce

Ionic sample app, open popover with arrow to true or/and mode=ios on desktop.

Code Reproduction URL

No response

Ionic Info

No response

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Jan 21, 2022
@sean-perkins
Copy link
Contributor

Thanks for reporting this issue @peterpeterparker!

This decision was made to alleviate some design flaws in the desktop implementation and work around a breaking change of changing the default value of arrow on popover.

Discussing with the team, we don't think that was the best solution.

We'll track this as a bug & regression from v5 behavior, likely removing the opinionation for desktop platform and requiring implementations to manually set that flag based on their design patterns.

We'll share an update when we have a decision. Thanks 👍

@sean-perkins sean-perkins added the package: core @ionic/core package label Jan 21, 2022
@ionitron-bot ionitron-bot bot removed the triage label Jan 21, 2022
@sean-perkins sean-perkins changed the title bug: popover arrow on desktop bug: popover arrow on desktop does not display Jan 21, 2022
@sean-perkins sean-perkins added type: bug a confirmed bug report v6 issues specific to Framework v6 labels Jan 21, 2022
@peterpeterparker
Copy link
Contributor Author

Thanks for the feedback @sean-perkins

@jansgescheit
Copy link
Contributor

We missing the arrow on desktop too. We use the popover as a tooltip and it is an important orientation aid on the screen.

@averyjohnston
Copy link
Contributor

This has been resolved via #25056 and the fix will be available in a future release of Ionic 👍

@ionitron-bot
Copy link

ionitron-bot bot commented May 4, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report v6 issues specific to Framework v6
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants