fix(modal): native keyboard will dismiss when bottom sheet is dragged #24642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #23878 Co-authored-by: EinfachHans <[email protected]>
|
@sean-perkins amazing!! Looks good so far 😊 Dev build would be awesome to test it in a dev app |
averyjohnston
approved these changes
Jan 24, 2022
@EinfachHans The dev build version is i.e.: npm i @ionic/[email protected] |
EinfachHans
approved these changes
Jan 25, 2022
liamdebeasi
reviewed
Jan 25, 2022
| /* tslint:disable-next-line */ | ||
| if (typeof document !== 'undefined') { | ||
| const activeElement = baseEl.ownerDocument.activeElement as HTMLElement; | ||
| if (activeElement.matches('input,ion-input,textarea,ion-textarea')) { |
There was a problem hiding this comment.
Sorry, I am a bit late but why don't we focus the ion-modal instead? If someone is using contenteditable this is still going to break.
13 tasks
This was referenced Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The swipe gesture for the modal bottom sheet will trigger when a form element (input, textarea, etc.) receives focus and opens the native keyboard. This causes the sheet gesture to become unresponsive and free scroll.
Issue Number: Resolves #23878
What is the new behavior?
Does this introduce a breaking change?
Other information
modal-sheet-before.mp4
modal-sheet-after.mp4
Behavior is easier to feel on device than from a video:
<ion-input></ion-input>for each item