fix(modal, popover): quickly opening modal/popover no longer presents duplicates #24697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
approved these changes
Feb 2, 2022
There was a problem hiding this comment.
Changes look good 👍 cannot think of a way to simulate that wouldn't be flaky, besides possibly opening a modal/popover, manually changing it's appearance to be not visible and then simulating the pointer events into the state that would align with double clicking the button that opens a modal.
averyjohnston
approved these changes
Feb 2, 2022
|
@agencia-estado Please open a new issue with a repo we can use to reproduce the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Given a button that calls
modalController.createandmodalController.present, double clicking it currently results in 2 modals being presented. This is technically the correct behavior, but it is undesirable to some developers.In Ionic 5, the modals/popovers would receive
pointer-eventsthe moment the presenting animation began, so this double modal behavior never happened. On the second click, the modal would receive the click causing the 2nd modal to not get presented.In Ionic 6, modals/popovers did not receive pointer events by default causing the behavior to reproduce more easily. The reason why it changed was due to a workaround to get inline modals to behave properly. However,
What is the new behavior?
display: noneso in that case pointer events are not received. This behavior only applies when the modal/popover is set to be presented.Does this introduce a breaking change?
Other information
Note: I wasn't able to create an automated test that wasn't flaky. If you have ideas for how I can better automate a test for this, let me know!