Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react, vue): scroll is no longer interrupted on ios #24791

Merged
merged 3 commits into from
Feb 17, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #24435

What is the new behavior?

  • body is now always promoted to its own layer. It was supposed to be its own layer even before this change, but there is a quirk in WebKit where this does not always happen.
    Typically we do not want to "force" layer promotion but given this is an instance where body is truly supposed to be its own layer, this seems like an acceptable exclusion to the rule.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi requested a review from a team as a code owner February 15, 2022 17:57
@liamdebeasi liamdebeasi requested review from averyjohnston and sean-perkins and removed request for a team February 15, 2022 17:57
@github-actions github-actions bot added the package: core @ionic/core package label Feb 15, 2022
@liamdebeasi
Copy link
Contributor Author

The timing of when things get promoted seem to be partially determined by when .ion-page is added to ion-app during the Stencil rendering lifecycle. After a day of testing, I was not able to isolate the issue enough to create a proper code reproduction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: vue, scroll position resets with swipe down
3 participants