-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(menu): preserve scroll position when focusing on open #25044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
reviewed
Apr 4, 2022
sean-perkins
approved these changes
Apr 6, 2022
6 tasks
liamdebeasi
reviewed
Apr 8, 2022
liamdebeasi
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Co-authored-by: Liam DeBeasi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
When an
ion-menu
is opened, the first (focusable) element inside it is auto-focused for screen readers. This causes the menu's scroll position to jump to the focused element, and only once the opening animation has finished, leading to a jarring experience.Issue URL: Resolves #24634
What is the new behavior?
When opening the menu, the host element is focused instead of the first element. This allows focus trapping without affecting the scroll position.
Does this introduce a breaking change?
Other information
An alternative would be to use the
preventScroll
option infocusFirstDescendant
:However, this isn't currently supported in Safari: https://caniuse.com/mdn-api_htmlelement_focus_options_preventscroll_parameter
Side note: I elected to write the test in Puppeteer for the sake of time, rather than migrating to Playwright.