fix(datetime): handle invalid dates when value changes

[sean-perkins]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build (npm run build) was run locally and any changes were pushed
• Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

When assigning an invalid value to a datetime in Firefox, such as:

document.querySelector('ion-datetime[presentation="time"]').value = '4:10'; // Valid value would be 04:10

In Firefox an exception will be thrown that states:

TypeError: parseDate(...) is undefined

This exception is not present in Safari or Chrome and isn't helpful or clear to developers.

What is the new behavior?

• Adds check for a valid parsable date before trying to assign active parts
• No exception is thrown in Firefox
• Warning is logged to the developer that an invalid date string was provided

Does this introduce a breaking change?

• Yes
• No

Other information

[liamdebeasi]

Looks good other than the comment. Don't forget to update the commit subject to be more descriptive. Maybe something like "warn when parsing an invalid date value"?

[liamdebeasi]

With the other fix I merged into main, is this still needed?

[sean-perkins]

The behavior it was added to resolve, was fixed by your other changes. There is some value of it existing, in that we shouldn't be calling setIonViewport on a test template that doesn't use ion-content. If we use the waitForSelector, an invalid test will fail and help inform that that tag is expected in the test file. I think this is rare though, so I'd be happy to remove for now and re-add if we would find value in the safe guard.