Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): button components now routes correctly without reload #25071

Merged
merged 12 commits into from
Apr 7, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Apr 7, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: #25014 (comment)

#25014 caused all routerLinks to perform a page reload which interfered with the local history of Ionic's routing integrations. This resulted in ion-back-button elements disappear because Ionic thought users could not go back.

This change was originally done to allow a elements to open links in new tabs via Ctrl+Click.

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi requested a review from a team as a code owner April 7, 2022 13:33
@github-actions github-actions bot added the package: angular @ionic/angular package label Apr 7, 2022
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Angular does have a router link implementation that targets specifically the a and area tags: https://github.com/angular/angular/blob/master/packages/router/src/directives/router_link.ts#L280-L281

Should we do a similar approach? Have the previous implementation pattern target a and have the updated implementation target the selector within this PR?

I believe with this change clicking the a tag without a new tab interaction, will not apply the element specific overrides for router direction & animation.

@liamdebeasi liamdebeasi merged commit 1c26e9b into main Apr 7, 2022
@liamdebeasi liamdebeasi deleted the angular-delegate-a branch April 7, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants