-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular): button components now routes correctly without reload #25071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Angular does have a router link implementation that targets specifically the a
and area
tags: https://github.com/angular/angular/blob/master/packages/router/src/directives/router_link.ts#L280-L281
Should we do a similar approach? Have the previous implementation pattern target a
and have the updated implementation target the selector within this PR?
I believe with this change clicking the a
tag without a new tab interaction, will not apply the element specific overrides for router direction & animation.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: #25014 (comment)
#25014 caused all routerLinks to perform a page reload which interfered with the local history of Ionic's routing integrations. This resulted in
ion-back-button
elements disappear because Ionic thought users could not go back.This change was originally done to allow
a
elements to open links in new tabs via Ctrl+Click.What is the new behavior?
a
elements from Ionic's routerLink delegate so that Ctrl+Click works correctly.Does this introduce a breaking change?
Other information