Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(all): import path is now correct when using ionic in a stencil app #25123

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25122

This appears to be a Stencil bug, but using a Stencil library with aliased paths inside of another Stencil library causes import errors. This does not happen in non-Stencil apps.

What is the new behavior?

  • Imports are now correct in Stencil apps

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi requested a review from a team as a code owner April 13, 2022 20:50
@github-actions github-actions bot added the package: core @ionic/core package label Apr 13, 2022
@liamdebeasi liamdebeasi changed the title fix(): import path is now correct when using ionic in a stencil app fix(all): import path is now correct when using ionic in a stencil app Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: stencil, alias import not working when using stencil app
3 participants