-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datetime): if no default value, don't highlight active day until one is selected #25151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
reviewed
Apr 25, 2022
liamdebeasi
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
sean-perkins
approved these changes
Apr 26, 2022
Closed
6 tasks
This was referenced May 1, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
When an
ion-datetime
is initialized without a value defined, today's date is highlighted with a solid blue circle. This is misleading, as it looks like a day has already been selected.Issue URL: #24456
What is the new behavior?
value
property is set to at that moment. (I.e. it's possible to trigger the solid circle, but still have a nullishvalue
.) This is to handle datetimes with confirm/cancel buttons, where thevalue
does not change untilconfirm
is called. (See: https://ionicframework.com/docs/api/datetime#confirming-selected-values)Does this introduce a breaking change?
Other information
value
in order to avoid unwantedionChange
events that would fire when the value is automatically switched to today.activeParts
to today if no initial value is set, but that would require allowingactiveParts
or all its properties to benull
, which would require a small refactor. I figure the current method is simpler and safer.6.1.2-dev.11650392645.12c652f6
(Posted in original issue)