Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): card modal no longer dismisses from content with refresher #25227

Merged
merged 2 commits into from
May 3, 2022

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

No issue link, but I discovered this issue when Venmoing someone last night 😂 . I had a native card modal open that used a refresher. The refresher always took priority over the swipe to dismiss gesture when swiping on the content.

What is the new behavior?

  • Swiping to dismiss from the content no longer happens if a refresher is present.
  • You can also implement this fix by changing the gesturePriority of the modal gesture. However, I opted not to do that for a few reasons:
  1. The refresher component has 3 different gestures in it (iOS native, MD native, and legacy). If any of those change, this will break.
  2. I was not able to easily evaluate what effect this priority change will have on the swipe to go back gesture (i.e. ion-nav with a swipe back gesture in modal). We do not have good test coverage in this area.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi requested a review from a team as a code owner May 3, 2022 13:10
@github-actions github-actions bot added the package: core @ionic/core package label May 3, 2022
@liamdebeasi liamdebeasi merged commit c4f811f into main May 3, 2022
@liamdebeasi liamdebeasi deleted the card-refresher branch May 3, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants