Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime): don't update value on confirm call if no date was selected #25338

Merged
merged 2 commits into from
May 24, 2022

Conversation

averyjohnston
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

If you have an ion-datetime with no default value (causing its value to init to undefined), and then call confirm on it without first selecting a date, the value will be updated to today. Because we updated the behavior such that no day is visually pre-selected until you pick one, this no longer makes sense.

Screencast: https://user-images.githubusercontent.com/90629384/169901184-eeb228f1-766b-4ce7-a818-f5d087d094ba.mp4

Issue URL: N/A

What is the new behavior?

The value is not updated on confirm call unless a day is selected first.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@averyjohnston averyjohnston requested a review from a team as a code owner May 23, 2022 20:35
@github-actions github-actions bot added the package: core @ionic/core package label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants