fix(datetime): emit ionChange for non-calendar picker presentation #25380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
When the
presentation
is not a calendar picker (time
,month-year
,month
oryear
), selecting a value does not emitionChange
, unless the datetime was initialized with a default value.This is due to this PR change: #25338
Issue URL: #25375
What is the new behavior?
The new value for the datetime will only be set if the check for a calendar picker with a new date selection is
true
or if the presentation of the datetime is oftime
,month
,year
ormonth-year
.Does this introduce a breaking change?
Other information
Dev-build:
6.1.8-dev.11654024993.1c2aa477
✅