Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime): emit ionChange for non-calendar picker presentation #25380

Merged
merged 6 commits into from
Jun 1, 2022

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented May 31, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When the presentation is not a calendar picker (time, month-year, month or year), selecting a value does not emit ionChange, unless the datetime was initialized with a default value.

This is due to this PR change: #25338

Issue URL: #25375

What is the new behavior?

The new value for the datetime will only be set if the check for a calendar picker with a new date selection is true or if the presentation of the datetime is of time, month, year or month-year.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev-build: 6.1.8-dev.11654024993.1c2aa477

@sean-perkins sean-perkins requested a review from a team as a code owner May 31, 2022 19:27
@github-actions github-actions bot added the package: core @ionic/core package label May 31, 2022
core/src/components/datetime/datetime.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@sean-perkins sean-perkins merged commit 4e6a60b into main Jun 1, 2022
@sean-perkins sean-perkins deleted the FW-1616 branch June 1, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants