-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modal): clicking handle advances to the next breakpoint #25540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
liamdebeasi
reviewed
Jun 30, 2022
Co-authored-by: Liam DeBeasi <[email protected]>
liamdebeasi
suggested changes
Jul 1, 2022
liamdebeasi
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Just a few small things below.
liamdebeasi
reviewed
Jul 5, 2022
averyjohnston
approved these changes
Jul 6, 2022
3 tasks
This was referenced Aug 1, 2022
This was referenced Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package: angular
@ionic/angular package
package: core
@ionic/core package
package: vue
@ionic/vue package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Clicking the sheet modal handles not advance to the next available breakpoint.
Issue URL: #24069
What is the new behavior?
handleBehavior
, which controls if clicking the sheet modal handle advances to the next available breakpoint.handleBehavior
defaults tonone
, meaning that existing sheet modals will need to opt-in to this behavior.handleBehavior
iscycle
, the handle element will be focusable and include aria-labels informing "Activate to adjust the size of the dialog overlaying the screen".Does this introduce a breaking change?
Other information