-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(angular, react, vue): add support for autoMountComponent #25552
Conversation
Bikeshedding a bit... I'm not a huge fan of
Anyone have a preference? I added reviewers to get feedback on the prop name. The code itself is the same code that was already reviewed. |
Maybe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions. Unsure how much of the language should be around the prop name vs. the behavior of the feature. I do not have any strong opinions on either.
Docs: ionic-team/ionic-docs#2432
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: Internal ticket.
What is the new behavior?
Does this introduce a breaking change?
Other information