-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(range): add reference point for start position of range slider #25598
Conversation
Co-authored-by: Sachin Garg <[email protected]>
Not sure why the accordion screenshot has a diff... going to add a task for that in our backlog and see if another run of updating the reference screenshots resolves it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the design doc, "If [the floor value] falls outside [max and min], a console warning will be logged for the developer and floor will fall back to the min value specified."
The warning is there, but the floor does not fall back to the min value.
Example:
<ion-range
class="ion-no-padding"
min="-100"
max="100"
snaps="10"
step="10"
pin="true"
bar-active-start="1000"
value="0"
>
</ion-range>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Good to go once my remaining comment has been addressed.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Developers are unable to specify a start position of the range bar. This prevents developers from having experiences where the start position may be fixed at "0", but have a min value of less than zero and a maximum value higher than zero.
For example, this is not possible:
Issue URL: #24348
What is the new behavior?
barActiveStart
property to enable developers to set the position the bar will begin from in the range slider (only available in single knob)Does this introduce a breaking change?
Other information
This PR is in favor of #24399, will give co-authored-by credit when merging.