fix(datetime): display time in user's timezone after selection #25694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
approved these changes
Aug 1, 2022
| new Date( | ||
| convertDataToISO({ | ||
| ...refParts, | ||
| tzOffset: undefined, |
There was a problem hiding this comment.
When fixing FW-1831, would this issue also get resolved? The solution for that issue may be to remove any timezone processing from convertDataToISO. If this issue would get resolved, it might be worth adding a TODO to make sure we remove this additional line since it would be redundant.
There was a problem hiding this comment.
Yes, should be resolved by any changes to convertDataToISO that ignores the timezone offset. I'll update to include the TODO.
averyjohnston
approved these changes
Aug 1, 2022
This was referenced Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
When datetime is rendered initially, the time is formatted with a
tzOffsetof0. When the time is manipulated in the time overlay/picker, thetzOffsetis applied (to the users timezone, i.e.-240) and incorrectly formats the displayed time.Issue URL: #25693
What is the new behavior?
tzOffsetwhen localizing the time for displayDoes this introduce a breaking change?
Other information
Dev-build:
6.2.1-dev.11659121131.15481a1f✅