fix(react): outlet will not clear in react 18 with hot reload #25703
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
In React 18, components are mounted/unmounted in dev build to check for side effects. The
StackManager
implementation has logic to clear the outlet when it is unmounted. Unfortunately this implementation of clearing the outlet has an innersetTimeout
that will resolve 500ms after it is invoked.This results in:
This is only a problem in React 18 & in development mode. Noticeable with hot reloading, as any changes will clear the view.
Issue URL: #25507
What is the new behavior?
Does this introduce a breaking change?
Other information
Dev-build:
6.2.1-dev.11659463817.1943a7f4
✅ (need to install for both@ionic/react
and@ionic/react-router
)