Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Refresher throws an exception in React/Vue on load #25782

Closed
4 of 7 tasks
sean-perkins opened this issue Aug 18, 2022 · 6 comments
Closed
4 of 7 tasks

bug: Refresher throws an exception in React/Vue on load #25782

sean-perkins opened this issue Aug 18, 2022 · 6 comments
Assignees
Labels
package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package type: bug a confirmed bug report

Comments

@sean-perkins
Copy link
Contributor

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x
  • Nightly

Current Behavior

The Refresher component throws an exception in the console when it loads, preventing the component from being usable.

An error from IonRefresher

Expected Behavior

The refresher should not throw any exceptions on load and should be interactive.

Steps to Reproduce

  1. Include ion-refresher in React/Vue template
  2. Observe: Exception is thrown when component loads

Code Reproduction URL

https://github.com/jameson-w-taylor/vue-refresher-error

Ionic Info

N/A

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Aug 18, 2022
@sean-perkins sean-perkins self-assigned this Aug 18, 2022
@sean-perkins sean-perkins added package: vue @ionic/vue package package: react @ionic/react package package: core @ionic/core package type: bug a confirmed bug report and removed triage labels Aug 18, 2022
@sean-perkins
Copy link
Contributor Author

Dev-build to resolve this issue: 6.2.4-dev.11660836281.1a11712b.

You can also downgrade to 6.2.2 in the interim. This bug only effects 6.2.3.

@Janaka-Steph
Copy link

Dev-build to resolve this issue: 6.2.4-dev.11660836281.1a11712b.

You can also downgrade to 6.2.2 in the interim. This bug only effects 6.2.3.

@sean-perkins Not related to this issue but trying 6.2.2 and 6.2.4-nightly.20220822 I have a new issue where useIonViewWillEnter is not executed...

@sean-perkins
Copy link
Contributor Author

@Janaka-Steph can you open a new issue with a reproduction so we can take a look?

@milanharia
Copy link

@sean-perkins seems like there is an issue with the refreshers on pages with IonContent fullscreen which have a color.

Simulator.Screen.Recording.-.iPhone.12.Pro.Max.-.2022-08-22.at.17.30.04.mp4

Code to reproduce this issue:

const Tab1: React.FC = () => {
  return (
    <IonPage>
      <IonHeader>
        <IonToolbar>
          <IonTitle>Tab 1</IonTitle>
        </IonToolbar>
      </IonHeader>
      <IonContent color="warning" fullscreen>
        <IonHeader collapse="condense">
          <IonToolbar color="warning">
            <IonTitle size="large">Tab 1</IonTitle>
          </IonToolbar>
        </IonHeader>
        <IonRefresher slot="fixed" onIonRefresh={doRefresh}>
          <IonRefresherContent></IonRefresherContent>
        </IonRefresher>
        <div className="center">
          <h1>Tab 1</h1>
        </div>
      </IonContent>
    </IonPage>
  );
};

@sean-perkins
Copy link
Contributor Author

@milanharia can you open a new issue with your expected behavior and a reproduction repository? This issue is focused on the exception that is currently thrown in React/Vue applications. This issue will automatically close when the associated PR is merged.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 21, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

3 participants