Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert): add default aria-label #25800

Merged
merged 2 commits into from
Aug 22, 2022
Merged

fix(alert): add default aria-label #25800

merged 2 commits into from
Aug 22, 2022

Conversation

averyjohnston
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): Accessibility-related fix

What is the current behavior?

ion-alert throws Axe accessibility violations by default due to not having an aria-label.

Issue URL: N/A (internal ticket)

What is the new behavior?

Default aria-label added, pulling from the alert's header (or subHeader if no header is defined) and falling back to simply 'Alert' if needed. Devs can already define a custom aria-label using the htmlAttributes property when presenting the alert.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@averyjohnston averyjohnston requested a review from a team as a code owner August 22, 2022 19:13
@github-actions github-actions bot added the package: core @ionic/core package label Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants