fix(vue): custom animation plays when replacing #25863
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #25831
By default, a replace operation should not play an animation. We accomplish this by setting the duration to
0
when calling IonRouterOutlet.commit. However, we should play an animation if a developer has explicitly passed a custom animation. Right now we do not, so all custom animations appear to not play.I also found that a test in
hooks.spec.ts
was testing the wrong behavior, even thoughuseIonRouter
states in the docs that you can pass a custom animation when doinguseIonRouter().replace(...)
: https://ionicframework.com/docs/vue/utility-functions#interfacesWhat is the new behavior?
hooks.sepc.ts
Does this introduce a breaking change?
Other information