Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(card): avoid force compositing on ios #25942

Merged
merged 3 commits into from
Sep 15, 2022
Merged

perf(card): avoid force compositing on ios #25942

merged 3 commits into from
Sep 15, 2022

Conversation

liamdebeasi
Copy link
Contributor

⚠️ Do not merge until #25941 is merged.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: Improves #25760

The Card on iOS uses transform: translateZ(0) to force browsers to composite the card. This is triggering the WebKit bug in #25760. We do not need this force compositing. Browsers can determine when to composite on their own and this code is causing unnecessary memory consumption.

What is the new behavior?

  • Remove the transform from ion-card on iOS mode.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Sep 14, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review September 14, 2022 19:29
@liamdebeasi liamdebeasi requested a review from a team as a code owner September 14, 2022 19:29
@liamdebeasi liamdebeasi merged commit 174c3b3 into main Sep 15, 2022
@liamdebeasi liamdebeasi deleted the card-transform branch September 15, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants