Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overlays): focus trapping no longer includes hidden elements #25948

Merged
merged 7 commits into from
Sep 15, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Sep 15, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: N/A internal ticket

When a hidden interactive if the first element, the focus trapping module tries to focus that element on tab. Since the element is hidden and not focusable, focus can escape from the overlay.

What is the new behavior?

  • Focus trapping excludes elements hidden with the hidden attribute.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Sep 15, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review September 15, 2022 17:01
@liamdebeasi liamdebeasi requested a review from a team as a code owner September 15, 2022 17:01
@liamdebeasi liamdebeasi merged commit 5c10f98 into main Sep 15, 2022
@liamdebeasi liamdebeasi deleted the FW-2257-a branch September 15, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants