Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime): switching month and year accounts for day #25996

Merged
merged 6 commits into from
Sep 23, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Sep 22, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25585

What is the new behavior?

  • Calling the setActiveParts function now validates that we are setting a valid date before activeParts is updated. This account for users who select a day and then change the month/year but changing the month/year impacts the maximum day that you can select (i.e. January 31 --> selecting February).

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Sep 22, 2022
@liamdebeasi liamdebeasi changed the title Fw 1821 fix(datetime): switching month and year accounts for day Sep 22, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review September 22, 2022 18:17
@liamdebeasi liamdebeasi requested a review from a team as a code owner September 22, 2022 18:17
core/src/components/datetime/datetime.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: datetime should preserve selected date when switching month/year
2 participants