Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(item, card): aria-label is reflected to the inner button #26028

Merged
merged 14 commits into from
Oct 10, 2022
Merged

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Sep 27, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

aria-label is not reflected to the focusable element (button) when using ion-item or ion-card.

Issue URL: #25885

What is the new behavior?

  • If an aria-label is set on an ion-card using button, it will be reflected to the inner button.
  • If an aria-label is set on an ion-item using button, it will be reflected to the inner button.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Opted against writing a spec test for ion-item, since it is rendered x2 on load, causing issues with the spec test.

Created a basic card template, since no example exists currently for quick preview/manipulation.

@github-actions github-actions bot added the package: core @ionic/core package label Sep 27, 2022
@sean-perkins sean-perkins marked this pull request as ready for review September 29, 2022 18:42
@sean-perkins sean-perkins requested a review from a team as a code owner September 29, 2022 18:42
core/src/components/card/card.tsx Outdated Show resolved Hide resolved
core/src/components/item/item.tsx Outdated Show resolved Hide resolved
core/src/utils/helpers.ts Outdated Show resolved Hide resolved
@liamdebeasi liamdebeasi changed the title fix(item,card): aria-label is reflected to the inner button fix(item, card): aria-label is reflected to the inner button Oct 10, 2022
@sean-perkins sean-perkins merged commit 3c89ebe into main Oct 10, 2022
@sean-perkins sean-perkins deleted the FW-2269 branch October 10, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants