-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datetime): setting date async updates calendar grid #26070
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
changed the title
DO NOT MERGE Fw 2062
fix(datetime): setting date async updates calendar grid
Oct 4, 2022
liamdebeasi
commented
Oct 4, 2022
sean-perkins
approved these changes
Oct 4, 2022
averyjohnston
approved these changes
Oct 5, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #25776
Setting
value
programmatically when no value was initially selected was not highlighting the correct day because of a defect in how we updatehighlightActiveParts
.activeParts
was originally designed to default to today's date when novalue
was set. This had the side effect of today's date being highlighted, indicating that it was selected, even ifvalue === undefined
.This was confusing, and we changed the behavior in #25151 so that today's date was outlined when it was not explicitly selected. However, we opted not to change the underlying behavior of
activeParts
defaulting to today. This behavior is what is ultimately responsible for the reported issue. (In other words, yeshighlightActiveParts
is preventing the datetime from working as expected, buthighlightActiveParts
exists becauseactiveParts
is not working correctly)activeParts
was designed to represent dates that had been selected by the user or today's date. Since defaulting to today's date is a behavior we are actively trying to avoid withhighlightActiveParts
,activeParts
should no longer default to today's date.What is the new behavior?
activeParts
now defaults to[]
instead of today's dateDoes this introduce a breaking change?
Other information