Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime): account for allowed values when setting default date #26093

Merged
merged 24 commits into from
Oct 26, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Oct 10, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #24722

What is the new behavior?

  • Creates separate DatetimeParts interfaces for today's date (which is now immutable) and the "default" date which. The "default" date is used as a fallback when there is no value set but we need to render some kind of date in the UI.
  • Updates the implementation of datetime to either use the default date or today's date. Anything that explicitly calls out today's date now uses todayParts (for example, getCalendarDayState, which highlights today's calendar day regardless of the *Values props or max/min).
  • Renames getDefaultPart to getActivePartsWithFallback so as to not collide with defaultParts.
  • Adjusts the "default" date so that it is use values specified by *Values props (if provided)
  • Updates the workingParts to default to default to defaultParts (this is done by adjusting the fallback in processValue)

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Oct 10, 2022
@liamdebeasi liamdebeasi changed the title DO NOT MERGE: fix(datetime): account for allowed values when setting default date fix(datetime): account for allowed values when setting default date Oct 11, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review October 11, 2022 18:09
@liamdebeasi liamdebeasi requested a review from a team as a code owner October 11, 2022 18:09
@averyjohnston averyjohnston requested a review from a team October 12, 2022 15:26
@liamdebeasi
Copy link
Contributor Author

This is blocked by #26121 and #26120

@liamdebeasi liamdebeasi requested review from sean-perkins and removed request for a team October 17, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: datetime, current minutes shown even if not included in minuteValue field
3 participants