Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): routing components define child components #26107

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Oct 12, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: N/A A bug was reported internally that the ripple effect was not working. This was because ion-tab-button was not registering it's child ion-ripple-effect component: https://github.com/mhartington/ionic-vue-vite-test

What is the new behavior?

  • "Hand crafted" Ionic Vue components (as opposed to autogenerated components in proxies.ts) now import and all the defineCustomElement function for each custom element provided by Stencil.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: vue @ionic/vue package label Oct 12, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review October 12, 2022 16:23
@liamdebeasi liamdebeasi requested a review from a team as a code owner October 12, 2022 16:23
@liamdebeasi liamdebeasi merged commit d60973b into main Oct 13, 2022
@liamdebeasi liamdebeasi deleted the vue-child-deps branch October 13, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants