Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime): values are adjusted to be in bounds #26125

Merged
merged 13 commits into from
Oct 17, 2022
Merged

fix(datetime): values are adjusted to be in bounds #26125

merged 13 commits into from
Oct 17, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Oct 13, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25894 resolves #25708

The wheel picker component that datetime uses has a built-in recovery system when value is no longer represented in items. The picker will scroll to the nearest item and update the value.

This was needed by ion-datetime when switching between min or max values such that the selected time become invalid. (i.e. selecting the min date that has a min time of 09:00 even though the previously selected time is 08:00).

This caused multiple render issues and unexpected value updates.

What is the new behavior?

  • Moves the adjustment logic out of the picker component and into datetime. Now the value will be adjusted as the state is being updated (whereas the picker was sometimes updating the state immediately after the state was already updated).
    Note: Ultimately, the team would like to move away from this automatic value adjustment and align more closely with the native datetime-local input behavior. However, that is a breaking change so we opted to fixing the existing behavior for now while we can evaluate alternatives.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Oct 13, 2022
@liamdebeasi liamdebeasi changed the title fix(datetime): values are now adjusted in bounds fix(datetime): values are adjusted to be in bounds Oct 13, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review October 13, 2022 21:00
@liamdebeasi liamdebeasi requested a review from a team as a code owner October 13, 2022 21:00
@averyjohnston averyjohnston requested a review from a team October 14, 2022 15:07
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
3 participants