-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datetime): values are adjusted to be in bounds #26125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
changed the title
fix(datetime): values are now adjusted in bounds
fix(datetime): values are adjusted to be in bounds
Oct 13, 2022
averyjohnston
approved these changes
Oct 14, 2022
sean-perkins
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work 👍
This was referenced Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #25894 resolves #25708
The wheel picker component that datetime uses has a built-in recovery system when
value
is no longer represented initems
. The picker will scroll to the nearest item and update the value.This was needed by
ion-datetime
when switching between min or max values such that the selected time become invalid. (i.e. selecting the min date that has a min time of 09:00 even though the previously selected time is 08:00).This caused multiple render issues and unexpected value updates.
What is the new behavior?
Note: Ultimately, the team would like to move away from this automatic value adjustment and align more closely with the native
datetime-local
input behavior. However, that is a breaking change so we opted to fixing the existing behavior for now while we can evaluate alternatives.Does this introduce a breaking change?
Other information