Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): inline overlays display contents consistently #26255

Merged
merged 3 commits into from
Nov 9, 2022
Merged

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Nov 9, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Presenting an inline overlay multiple times in React will hide the overlay contents on the second+ open.

Issue URL: #26253

What is the new behavior?

  • Adds the ion-delegate-host class to the React wrapper, so the additional element is not created
  • Inline overlay contents are consistently displayed when presenting

Does this introduce a breaking change?

  • Yes
  • No

Other information

Testing these changes:

  • Run the React test-app
  • Visit the Keep Contents Mounted test suite
  • Present a modal
  • Observe: Contents load/display
  • Dismiss modal
  • Present modal again
  • Observe: Contents should load/display consistently

Dev-build: 6.3.6-dev.11668017847.1d5c7dbd

@sean-perkins sean-perkins requested a review from a team as a code owner November 9, 2022 18:00
@github-actions github-actions bot added the package: react @ionic/react package label Nov 9, 2022
@sean-perkins sean-perkins changed the title test(react): inline overlay contents are visible when presented fix(react): inline overlay contents are visible when presented Nov 9, 2022
@sean-perkins sean-perkins changed the title fix(react): inline overlay contents are visible when presented @sean-perkins fix(react): inline overlays display contents consistently Nov 9, 2022
@sean-perkins sean-perkins changed the title @sean-perkins fix(react): inline overlays display contents consistently fix(react): inline overlays display contents consistently Nov 9, 2022
@sean-perkins sean-perkins merged commit d709ff6 into main Nov 9, 2022
@sean-perkins sean-perkins deleted the FW-2778 branch November 9, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react @ionic/react package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants