Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): popover positioning for controller and inline #26274

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Originally we believed that the popover positioning was only incorrect for inline overlays. This was not the case and controller overlays will also incorrectly position when using auto width.

Issue URL: #24716

What is the new behavior?

  • Removes the check for only applying the fix to inline overlays
  • Controller overlays will position correctly with auto width.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev-build: 6.3.7-dev.11668193398.1b5ffdd3
Reproduction: https://github.com/EinfachHans/ionic-popover-arrow-bug

@sean-perkins sean-perkins requested a review from a team as a code owner November 11, 2022 19:34
@github-actions github-actions bot added the package: core @ionic/core package label Nov 11, 2022
@sean-perkins sean-perkins merged commit 31ab10d into main Nov 14, 2022
@sean-perkins sean-perkins deleted the fix/popover-positioning branch November 14, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants