-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(card): border radius does not overflow on paint in Safari #26539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there diffs on Google Chrome?
@sean-perkins Do we still want to merge this? |
@liamdebeasi yes I do, I need to rebase and re-run the screenshot job as well. I don't have an answer as to why there are diffs in Google Chrome - outside of the assumption that these styles have a minor visual rendering difference on Chrome (but oddly for only 1 specific template). |
702867d
to
be51e7c
Compare
Ok - it looks like the diff is consistent, but I would be comfortable moving forward with it for the benefit it brings (solving the Safari 16 border radius overflow). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine moving forward with this. There is a slight change to chrome, but that could be intentional based on how contain: content
was implemented in that browser. The value add (fixing this bug in Safari) is greater than the small layout change in Chrome.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
In Safari 16:
The card border radius is not respected on the initial paint and the list edges will overflow the container. This is not present in Safari 15.
Isolating the styles, the
contain: content
(specificallycontain: paint
) causes the list overflow to be visible in Safari 16.Reproduction of issue: https://stackblitz.com/edit/angular-cnclwc-yhx4lf
Issue URL: #26529
What is the new behavior?
contain: content
on theion-card
so that the descendents overflows respect the containing element's box sizing.ion-card
border radius does not overflow in Safari 16.Reproduction with dev-build changes: https://stackblitz.com/edit/angular-cnclwc-4myqzy
Does this introduce a breaking change?
Other information
Dev-build:
6.4.2-dev.11672163551.15de10fd