Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal, popover): warn if trigger element was not found #26650

Merged
merged 3 commits into from
Jan 20, 2023

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jan 20, 2023

Note: I will put up a separate patch for v7 since how triggers are consumed has changed slightly.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

There is some developer confusion about how the trigger prop works. See #26648

What is the new behavior?

  • Both modal and popover have been updated to a) return early in configureTriggerInteraction if no trigger prop is set and b) warn if a trigger prop is set but the element was not found in the DOM.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz
Copy link

stackblitz bot commented Jan 20, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label Jan 20, 2023
@liamdebeasi liamdebeasi changed the title chore(overlays): modal and popover if trigger not found fix(modal, popover): warn if trigger element was not found Jan 20, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review January 20, 2023 17:18
@liamdebeasi liamdebeasi requested a review from a team as a code owner January 20, 2023 17:18
@liamdebeasi liamdebeasi merged commit 1115203 into main Jan 20, 2023
@liamdebeasi liamdebeasi deleted the overlay-trigger-help branch January 20, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants