fix(tap-click): instant activate does not use a setTimeout

[liamdebeasi]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
• Build (npm run build) was run locally and any changes were pushed
• Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

The tap click test is flaky on CI: https://github.com/ionic-team/ionic-framework/actions/runs/3652255155/jobs/6170488149

I think this is happening due to our usage of setTimeout. The callback may fire later (https://developer.mozilla.org/en-US/docs/Web/API/setTimeout#reasons_for_delays_longer_than_specified) and I think this is what was causing the flakiness.

What is the new behavior?

• Added .ion-activatable-instant to the tap click utility and re-enabled the test.
• Changed the .ion-activatable-instant behavior to add the .ion-activated class synchronously instead of in a setTimeout with a delay of 0. This avoids the use of setTimeout when testing this on CI.

Does this introduce a breaking change?

• Yes
• No

Other information

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.