feat(picker-column): assign custom aria-labels to column options #26749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Developers cannot assign an
aria-label
to the individual button items in a picker column.Issue URL:
What is the new behavior?
ariaLabel
to a picker column option, to assign thearia-label
to the rendered button.Does this introduce a breaking change?
Other information
Note: Stencil has something strange happening with the spec tests. Since the picker column uses timeouts, you will receive an exception if the tests are located in the same file. The issue doesn't occur if you place the spec tests in separate files. I experimented with Jest timer mocks and this appears to be a Stencil issue. The team has asked I create a minimal reproduction for them to dig into, which will require additional time and isn't a blocker for this feature.