Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(picker-column): assign custom aria-labels to column options #26749

Merged
merged 4 commits into from
Feb 13, 2023

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Developers cannot assign an aria-label to the individual button items in a picker column.

Issue URL:

What is the new behavior?

  • Developers can optionally assign an ariaLabel to a picker column option, to assign the aria-label to the rendered button.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Note: Stencil has something strange happening with the spec tests. Since the picker column uses timeouts, you will receive an exception if the tests are located in the same file. The issue doesn't occur if you place the spec tests in separate files. I experimented with Jest timer mocks and this appears to be a Stencil issue. The team has asked I create a minimal reproduction for them to dig into, which will require additional time and isn't a blocker for this feature.

@stackblitz
Copy link

stackblitz bot commented Feb 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label Feb 7, 2023
@sean-perkins sean-perkins marked this pull request as ready for review February 9, 2023 19:00
@sean-perkins sean-perkins requested a review from a team as a code owner February 9, 2023 19:00
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, but otherwise this looks great.

@sean-perkins sean-perkins merged commit daa89a2 into feature-6.6 Feb 13, 2023
@sean-perkins sean-perkins deleted the FW-1900 branch February 13, 2023 21:30
liamdebeasi added a commit to ionic-team/ionic-docs that referenced this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants